Fix pointer-to-member-function param with ref-qualifier (#56219)#56219
Closed
j-piasecki wants to merge 6 commits intofacebook:mainfrom
Closed
Fix pointer-to-member-function param with ref-qualifier (#56219)#56219j-piasecki wants to merge 6 commits intofacebook:mainfrom
j-piasecki wants to merge 6 commits intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
facebook-github-tools
bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D98123353. |
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Mar 25, 2026
Summary: Changelog: [Internal] Doxygen has a bug where it incorrectly embeds the parameter name of pointer-to-member-function parameters with ref-qualifiers (& or &&) into the type string instead of providing a separate <declname> element. This caused the snapshot to output `R(folly::dynamic::*)() const asFoo&` instead of the correct `R(folly::dynamic::*asFoo)() const &`. This diff detects the misplaced name in the type string and reconstructs the correct pointer-to-member declarator. Differential Revision: D98123353
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Mar 25, 2026
Summary: Changelog: [Internal] Doxygen has a bug where it incorrectly embeds the parameter name of pointer-to-member-function parameters with ref-qualifiers (& or &&) into the type string instead of providing a separate <declname> element. This caused the snapshot to output `R(folly::dynamic::*)() const asFoo&` instead of the correct `R(folly::dynamic::*asFoo)() const &`. This diff detects the misplaced name in the type string and reconstructs the correct pointer-to-member declarator. Differential Revision: D98123353
added 5 commits
March 25, 2026 23:59
Summary: Changelog: [Internal] Correctly handles array types in member definitions in the API snapshot. Differential Revision: D97923375
Summary: Changelog: [Internal] When a class has multiple base classes, all defining a constructor with the same signature, the inherited constructors were being duplicated in the snapshot (for each base class). This diff deduplicates them. Differential Revision: D98102286
Summary: Changelog: [Internal] Snapshot generator was putting `[]` in wrong place when generating array type - it was adding it to the type name instead of the variable name. This diff addresses that. Differential Revision: D98102328
Summary: Changelog: [Internal] Doxygen may incorrectly cross-reference parameter names inside function pointer types to member variables of the enclosing class. For example, `void (*cb)(const void* data)` inside a class that has a `data` member would produce `const void* Class::data` instead of `const void* data` in the snapshot. This diff addresses two issues: 1. In `get_doxygen_params`, re-parse function pointer type strings through `parse_type_with_argstrings` which delegates to `_parse_single_argument` that already strips "::" from parameter names. 2. In `parse_type_with_argstrings`, recognize complex declarator groups starting with `*` or `&` (e.g. `*(*fp)(int)`) as non-argument-list parenthesized sections, preventing incorrect name extraction from nested function pointer declarators. Differential Revision: D98118629
Summary: Changelog: [Internal] When a class inherits constructors via `using Base::Base;`, Doxygen incorrectly emits duplicate `basecompoundref` entries for the same base class. This caused base classes like `ConverterBase` to appear twice in the snapshot output. This diff deduplicates base classes by name in `get_base_classes()`. Differential Revision: D98118659
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Mar 26, 2026
Summary: Changelog: [Internal] Doxygen has a bug where it incorrectly embeds the parameter name of pointer-to-member-function parameters with ref-qualifiers (& or &&) into the type string instead of providing a separate <declname> element. This caused the snapshot to output `R(folly::dynamic::*)() const asFoo&` instead of the correct `R(folly::dynamic::*asFoo)() const &`. This diff detects the misplaced name in the type string and reconstructs the correct pointer-to-member declarator. Reviewed By: cipolleschi Differential Revision: D98123353
meta-codesync
bot
changed the title
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Mar 26, 2026
Summary: Changelog: [Internal] Doxygen has a bug where it incorrectly embeds the parameter name of pointer-to-member-function parameters with ref-qualifiers (& or &&) into the type string instead of providing a separate <declname> element. This caused the snapshot to output `R(folly::dynamic::*)() const asFoo&` instead of the correct `R(folly::dynamic::*asFoo)() const &`. This diff detects the misplaced name in the type string and reconstructs the correct pointer-to-member declarator. Reviewed By: cipolleschi Differential Revision: D98123353
j-piasecki
force-pushed
the
export-D98123353
branch
2 times, most recently
from
b44e926 to
052515c
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Mar 26, 2026
Summary: Changelog: [Internal] Doxygen has a bug where it incorrectly embeds the parameter name of pointer-to-member-function parameters with ref-qualifiers (& or &&) into the type string instead of providing a separate <declname> element. This caused the snapshot to output `R(folly::dynamic::*)() const asFoo&` instead of the correct `R(folly::dynamic::*asFoo)() const &`. This diff detects the misplaced name in the type string and reconstructs the correct pointer-to-member declarator. Reviewed By: cipolleschi Differential Revision: D98123353
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Mar 26, 2026
Summary: Changelog: [Internal] Doxygen has a bug where it incorrectly embeds the parameter name of pointer-to-member-function parameters with ref-qualifiers (& or &&) into the type string instead of providing a separate <declname> element. This caused the snapshot to output `R(folly::dynamic::*)() const asFoo&` instead of the correct `R(folly::dynamic::*asFoo)() const &`. This diff detects the misplaced name in the type string and reconstructs the correct pointer-to-member declarator. Reviewed By: cipolleschi Differential Revision: D98123353
j-piasecki
force-pushed
the
export-D98123353
branch
from
052515c to
bc6033e
Compare
Summary: Pull Request resolved: facebook#56219 Changelog: [Internal] Doxygen has a bug where it incorrectly embeds the parameter name of pointer-to-member-function parameters with ref-qualifiers (& or &&) into the type string instead of providing a separate <declname> element. This caused the snapshot to output `R(folly::dynamic::*)() const asFoo&` instead of the correct `R(folly::dynamic::*asFoo)() const &`. This diff detects the misplaced name in the type string and reconstructs the correct pointer-to-member declarator. Reviewed By: cipolleschi Differential Revision: D98123353
j-piasecki
force-pushed
the
export-D98123353
branch
from
bc6033e to
5a4c9eb
Compare
|
This pull request has been merged in f516811. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Doxygen has a bug where it incorrectly embeds the parameter name of pointer-to-member-function parameters with ref-qualifiers (& or &&) into the type string instead of providing a separate element.
This caused the snapshot to output
R(folly::dynamic::*)() const asFoo&instead of the correctR(folly::dynamic::*asFoo)() const &.This diff detects the misplaced name in the type string and reconstructs the correct pointer-to-member declarator.
Reviewed By: cipolleschi
Differential Revision: D98123353